fix: trunc function with precision uses round instead of trunc semantics #19794
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
martin-g
reviewed
Jan 15, 2026
|
|
||
| assert_eq!(floats.len(), 5); | ||
| assert_eq!(floats.value(0), 15.0); | ||
| assert_eq!(floats.value(1), 1_234.268); |
Member
There was a problem hiding this comment.
why is this assertion removed ?
Contributor
Author
There was a problem hiding this comment.
Oops, I might have accidently deleted the line during editing.
martin-g
approved these changes
Jan 15, 2026
Contributor
|
Thanks @kumarUjjawal & @martin-g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
roundinstead oftruncsemantics #19793.Rationale for this change
The helper functions
compute_truncate32andcompute_truncate64incorrectly use.round()instead of.trunc(), causing incorrect results:trunc(3.76, 1)returned3.8(wrong - rounded)trunc(3.76, 1)should return3.7(correct - truncated)What changes are included in this PR?
.round()to.trunc()incompute_truncate32andcompute_truncate64Are these changes tested?
Yes. Unit tests updated and pass.
Are there any user-facing changes?